Lapras

SW Application

Recommended Posts

Lapras   

I would like to apply to SW. I have created a hill giant killer capable of banking for food and hopping worlds, and in the future will be extending it to be able to run from 1/1/1 to 60/60/60 combining with other scripts I have. I also have another simple fly fisher with a GUI option for powerfishing or banking and paint for xp/fish count tracking if i should post that as well. Open to all feedback.

 

https://github.com/justinwagoner3/scripts

https://www.powerbot.org/community/topic/1352224-hill-giant-killer/

 

Share this post


Link to post


2 hours ago, JustinWagoner3 said:

I would like to apply to SW. I have created a hill giant killer capable of banking for food and hopping worlds, and in the future will be extending it to be able to run from 1/1/1 to 60/60/60 combining with other scripts I have. I also have another simple fly fisher with a GUI option for powerfishing or banking and paint for xp/fish count tracking if i should post that as well. Open to all feedback.

 

https://github.com/justinwagoner3/scripts

https://www.powerbot.org/community/topic/1352224-hill-giant-killer/

 

Let me start with what I like.

Semver, Very few people realize how important revisioning is.

Early returns in activation, good job!

And now to things that are a bit iffy for me.

https://github.com/justinwagoner3/scripts/blob/7b1efc9f6eb5c7cbd1089822be2bad197fb58114/utils/Food.java#L4

From my understanding, that's a constant meant to held ids of supported food. There is no reason for it to have a constructor.

The same thing is applicable to Monster and Traversal.

https://github.com/justinwagoner3/scripts/blob/7b1efc9f6eb5c7cbd1089822be2bad197fb58114/scripts/HillGiantKiller.java#L20

I strongly recommend making a TaskScript instead of just extending polling script everytime.

https://github.com/justinwagoner3/scripts/blob/7b1efc9f6eb5c7cbd1089822be2bad197fb58114/Tasks/Attack.java#L20

Let constants be accessed as constants, don't make static holders to reassign constants at runtime, that makes no sense. I'm guessing this will be a repeating trend in the other classes too.

Another thing, don't use System.out.println, it becomes really hard to maintain and disable. Use a singleton logger if you must or share your logger through ctx.controller.script.

https://github.com/justinwagoner3/scripts/blob/7b1efc9f6eb5c7cbd1089822be2bad197fb58114/Tasks/HopWorlds.java#L33

Use lambdas instead of instantiation.

https://github.com/justinwagoner3/scripts/blob/7b1efc9f6eb5c7cbd1089822be2bad197fb58114/Tasks/HopWorlds.java#L42

Firstly, don't separate RT utils. Let them stay in ctx. Also, I don't see where you initialized it.

https://github.com/justinwagoner3/scripts/blob/7b1efc9f6eb5c7cbd1089822be2bad197fb58114/Tasks/AntiBan.java#L16

Use Random.nextGaussian.

 

These are minor things though and hence, i'm in support of you getting the rank. You have been much better than a few recent SWs in my opinion.

 

Edited by DopeAssFreshPrince

Share this post


Link to post
Lapras   
9 hours ago, DopeAssFreshPrince said:

Let me start with what I like.

Semver, Very few people realize how important revisioning is.

Early returns in activation, good job!

And now to things that are a bit iffy for me.

https://github.com/justinwagoner3/scripts/blob/7b1efc9f6eb5c7cbd1089822be2bad197fb58114/utils/Food.java#L4

From my understanding, that's a constant meant to held ids of supported food. There is no reason for it to have a constructor.

The same thing is applicable to Monster and Traversal.

https://github.com/justinwagoner3/scripts/blob/7b1efc9f6eb5c7cbd1089822be2bad197fb58114/scripts/HillGiantKiller.java#L20

I strongly recommend making a TaskScript instead of just extending polling script everytime.

https://github.com/justinwagoner3/scripts/blob/7b1efc9f6eb5c7cbd1089822be2bad197fb58114/Tasks/Attack.java#L20

Let constants be accessed as constants, don't make static holders to reassign constants at runtime, that makes no sense. I'm guessing this will be a repeating trend in the other classes too.

Another thing, don't use System.out.println, it becomes really hard to maintain and disable. Use a singleton logger if you must or share your logger through ctx.controller.script.

https://github.com/justinwagoner3/scripts/blob/7b1efc9f6eb5c7cbd1089822be2bad197fb58114/Tasks/HopWorlds.java#L33

Use lambdas instead of instantiation.

https://github.com/justinwagoner3/scripts/blob/7b1efc9f6eb5c7cbd1089822be2bad197fb58114/Tasks/HopWorlds.java#L42

Firstly, don't separate RT utils. Let them stay in ctx. Also, I don't see where you initialized it.

https://github.com/justinwagoner3/scripts/blob/7b1efc9f6eb5c7cbd1089822be2bad197fb58114/Tasks/AntiBan.java#L16

Use Random.nextGaussian.

 

These are minor things though and hence, i'm in support of you getting the rank. You have been much better than a few recent SWs in my opinion.

 

 

Hey thank you for these tips! I will begin implementing tonight if i get off work early enough 👍

Share this post


Link to post
Coma   

Promoted.
 
Being a Script Writer, you have access to your own dedicated, private Git repository for your code hosted by us.
Your repo URL is powerbot.org/developer/git/[user id]/scripts. More info here.
 
There are lots of open Requests that need filled should you find yourself with free time.

Share this post


Link to post
Guest
This topic is now closed to further replies.