125 replies to this topic

[Ministry]

MinistryOfWater v1.5

Last updated: 05/09/11 | By Ministry ©

- Description -
This script does all things water, it fills empty jugs, vials or bowls at a water source and banks.
Also has support for drinking jugs of wine and filling them in one action.

- Features -
- Multiple locations (Varrock east, Falador west, Grand Exchange)
- Fill either vials, jugs or bowls with water
- Able to drink jugs of wine
- Very detailed paint (Finishing p/h, percent bar until finished, profit p/h)
- Interactive paint (Hover to view profit, hide with the up chat scroll arrow)
- Easy to use GUI
- Fast, smooth, flawless (?)

- Instructions -
- Start at either the water source or the bank you're going to be using
- If you're using Grand Exchange start at North-west bankers
- Make sure the items are visible in your bank
- Start the script and fill out your desired settings in the GUI

- Change log -

1.5 - Added camera turning to Grand Exchange, should now be slightly more efficient.
1.4 - Added Grand Exchange to locations, changed banking from booths to bankers.
1.3 - Method overhaul, optimized and increased efficiency. Added ability to toggle to rest or not. (1k+ jugs/hr)
1.2 - Added support for filling empty bowls. Fixed a few calculating issues.
1.1 - Fixed profit calculations and jug filling after drinking all wine.
1.0 - Initial Release

- Download & Details -
- Please post any feedback in this thread, including bugs and suggestions.
- Progress reports are GREATLY appreciated.
- Save as MinistryOfWater.java
Download
Please sell your full jugs/vials for mid or above!



- Progress reports -

sir_diablo, on 16 July 2011 - 06:02 AM, said:

http://i56.tinypic.com/5v6ovk.png

goodsandwich, on 02 August 2011 - 06:01 AM, said:

http://i1104.photobu...ng?t=1310764003

[Proggyman]

Nice script. Been running for 15 minutes and all is good. Flawless! so far

[Ministry]

Proggyman, on 14 July 2011 - 09:48 AM, said:

Nice script. Been running for 15 minutes and all is good. Flawless! so far

Enjoy. Post a progress report once you're done if you can please.

[rpthi3f]

this looks pretty beast im going to give it a try tmr and post a proggy

[BOSTON_BOY]

thers a problem when closing the bank interface, other then that nice script bro!

EDIT: nevermind, my mouse speed was just off, ill try to post proggies

Edited by BOSTON_BOY, 15 July 2011 - 04:41 PM.

[sir_diablo]

Here's my 4h44m43s proggy:

This model witout texture looks amazing:



All except profit calculate works perfect:



Im trying to sell jugs of water for 98gp each, profit calc should  do 4256 * 25 = 106400. 106400-for this cash i bought that jugs of wine. So i will get 310688 profit if some1 should buy water jugs 98gp each

[Ministry]

sir_diablo, on 16 July 2011 - 06:02 AM, said:

Here's my 4h44m43s proggy:

This model witout texture looks amazing:

All except profit calculate works perfect:

http://i1104.photobu...ng?t=1310764002

Im trying to sell jugs of water for 98gp each, profit calc should  do 4256 * 25 = 106400. 106400-for this cash i bought that jugs of wine. So i will get 310688 profit if some1 should buy water jugs 98gp each

I wasn't too sure if I did fix up the profit properly, I only quickly added the onFinish log statements but this is basically how it's calculated : -

Price of a Jug of water is grabbed from the GE (Currently like, 90gp?) and it subtracts the cost of the price of a Jug of wine (currently like 25?) and * that by the amount drank. But at the same time it adds in the amount of empty jugs just filled (I'm still not sure if after it finishes drinking all jugs of wine, if there's empty jugs in the bank it will fill them before stopping?) so full jug price minus empty Jug price * filled.
filled * (full jug minus empty jug) + drank * (full jug minus wine price).

Well either way, I'll look at it now and fix it, will edit in when I'm done.

Edit: Should be fixed now I think.
It adds the profit of jugs filled (without drinking) and jugs drank.
Same method for calcing profit:

profitEaInven = jugFPrice-winePrice;
	profitWine = profitEaInven*banked;
	profitHourWine = (int) ((profitWine) * 3600000D/ (System.currentTimeMillis() - startTime));

Updated to 1.1, enjoy.
Thank you for the progress report and feedback, much appreciated.

[sir_diablo]

Funny bug with "% done" when i start script with some empty jugs and jugs of wine in inventory:

Wine drinking and filling jugs with water is so nice way to earn gold on f2p now.
Clay miner+softener - 22k rsgp/h
ChoppingBeast oaks - 15k rsgp/h yews - 20k rsgp/h
Smelting steel bars - 40-50k rsgp/h
MinistryOfWater - 60-70k rsgp/h
PatyFaty tanner on f2p - max 70k rsgp/h p2p - max 300k rsgp/h
BTW. PatyFaty tanner working soooo slow on this computer with 512mb ram, i will use it on my own computer with 3gb ram and better processor, but after vacations.
I think drinking wine and fill empty jugs with water is better than chopping down yews with rest of bots.

[Ministry]

sir_diablo, on 16 July 2011 - 07:16 PM, said:

Funny bug with "% done" when i start script with some empty jugs and jugs of wine in inventory:
http://i1104.photobu...ng?t=1310843178
Wine drinking and filling jugs with water is so nice way to earn gold on f2p now.
Clay miner+softener - 22k rsgp/h
ChoppingBeast oaks - 15k rsgp/h yews - 20k rsgp/h
Smelting steel bars - 40-50k rsgp/h
MinistryOfWater - 60-70k rsgp/h
PatyFaty tanner on f2p - max 70k rsgp/h p2p - max 300k rsgp/h
BTW. PatyFaty tanner working soooo slow on this computer with 512mb ram, i will use it on my own computer with 3gb ram and better processor, but after vacations.
I think drinking wine and fill empty jugs with water is better than chopping down yews with rest of bots.

Thanks, I was/am aware of the bug with the % counter, but I wasn't able to figure out why it did it so therefore couldn't fix it. Now that you've pointed out it's cause I'll work on fixing it and edit in 1.2 after I finish my homework. Thanks.

[Dcrules8383]

Could you please update the script? With the release of v257 it has a compile error. I'de really like to use this on my skiller account. Thank you in advance.

[Ministry]

Dcrules8383, on 18 July 2011 - 10:13 AM, said:

Could you please update the script? With the release of v257 it has a compile error. I'de really like to use this on my skiller account. Thank you in advance.

It would help if you could post the compile error as it compiles entirely fine for me and I've been using it on 2.57 and beyond.

[spider7423]

This works. Gets me about 49k/h but because I have a slow computer.

[Dcrules8383]

Ministry, on 18 July 2011 - 11:24 AM, said:

It would help if you could post the compile error as it compiles entirely fine for me and I've been using it on 2.57 and beyond.

This is what I receive when I try to compile it. All of my other scripts compile completely fine though..

[YourMother99]

thanks a lot for this great script

[Ministry]

Dcrules8383, on 18 July 2011 - 06:28 PM, said:

This is what I receive when I try to compile it. All of my other scripts compile completely fine though..

That isn't an error it's just saying the script has an outdated method but will still work.

[Dcrules8383]

Ministry, on 18 July 2011 - 10:19 PM, said:

That isn't an error it's just saying the script has an outdated method but will still work.

Well it's not showing up in my scripts list when i use rsbot. What can i do to fix it and make it "still work"?

[Ministry]

Dcrules8383, on 18 July 2011 - 11:19 PM, said:

Well it's not showing up in my scripts list when i use rsbot. What can i do to fix it and make it "still work"?

Not sure, mine gives the some deprecated 'error' yet shows fine in my client.

[Da_D_Master]

1hr20min proggy filling empty jugs

[Ministry]

Thanks DMaster (Y)
Any suggestions?

[Da_D_Master]

Perhaps allow bowl filling seeing as its best profit apart from jugs of wine. However, it'd be quicker as you don't need to drink the wine first.

bowls = 43gp per
jug = 28pg per
jug of wine = 53gp per
vial = 15gp per