superchaoran

Smoke Rune Runner 1m-3m/hr

Recommended Posts

Smoke Rune Runner

According to this youtube video

RuneScape: Money Making Guide! - 3.6/3.9M Per Hour!!

 

 

This method can earn up to 3m/hr when market is good, but make sure you always test price on GE before your task.

 

Instruction

Watch this video before you start, make sure you have correct inventory.

RuneScape: Money Making Guide! - 3.6/3.9M Per Hour!!

Start at Castle Wars Arena Bank.

Make sure you have plenty of Ring of Dueling(8), Binding necklace, fire tira, large & giant pouch, air runes, fire tira and air talisman. Details see youtube video and screenshots.

 

Use screenshot as your preset 1.

 

Script Feature:

1.Auto detect where player is at, either at arena bank, outside alter or inside.

2.Save ring of Dueling(1) and (2) for later sale at GE, only use ring of Dueling(3-8).

3.Making player bank, teleport, run to fire rune alter, craft smoke rune then teleport back and bank.

4.Ambiguous traversing antipattern.

 

Profit: 1m -3m /hr

 

XP: around 20k-30k/hr

 

Screenshot:

33U7ttD.png

Future Development:

Support NPC Contact, support various pouches, support statistics, preset preset for you!

Github

https://github.com/superchaoran/powerbot/tree/scripts/src/superchaoran/RuneCrafting

 

I just noticed i had the title wrong, should be smoke rune runner. Anyway to change topic title? Thanks!

Edited by superchaoran

Share this post


Link to post


zigress   

Good script! Suggestion - maybe add a paint that shows profit/hr? Also, I feel like withdrawing stuff from bank (the right clicking) is kinda fast. No other issues.

Edited by zigress

Share this post


Link to post
Mooshe   

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L74

It's not necessary to sleep; RSBot will handle reaction delays which are unique per user.

 

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L77

Make use of the boolean presetGear1() to make sure it filled the inventory with the preset gear, and then have a wait condition to check if the bank is still open.

 

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L98

Too repetitive.

for(Item i : ctx.backpack.select().id(5512, 5513, 5514, 5515))
  i.interact("Fill");

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L112-L116

return ctx.bank.opened();

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L120

It would be better to use names.

 

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L143

Action bar may not be active. Make sure to check if legacy mode is disabled. Also, since people can define their own key binds, use:

ctx.input.send(ctx.combatBar.actionAt(0).bind())

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L151

Euclidean distance will never be negative. If the distance is incalculable (i.e. separate planes or null), it will return Double#POSITIVE_INFINITY. Also, you don't need to grab the Tile instance from a Tile; it is itself.

 

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L190

Step before calling camera turns; this will save time and not wait for the camera to stop turning before stepping.

 

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L201-L208

way too repetitive and detectable. Are you trying to move the camera up?

 

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L211

This will click the object, despite if something is in front of it. Use GameObject#interact(String action, String option) to prevent this, for example:

ctx.objects.peek().interact("Enter", ctx.objects.peek().name());

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L259

I imagine these are magic lamps? You'll need to rub each one, so do:

for(Item i : ctx.inventory.select().id(MAGIC_LAMPS))
  i.interact("rub");

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L294

One too many brackets.

 

 

----

 

The script has a lot of repetition and easily-detectable patterns.

 

The script does too many actions in one poll() call (should be limited to 1 each call so the script doesn't hang too long after being suspended).

Share this post


Link to post

Thanks for reviewing my code,  Mooshe. Your comments are very constructive.

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L74

It's not necessary to sleep; RSBot will handle reaction delays which are unique per user. (fixed)

 

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L77

Make use of the boolean presetGear1() to make sure it filled the inventory with the preset gear, and then have a wait condition to check if the bank is still open.(fixed)

 

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L98

Too repetitive.(fixed)

for(Item i : ctx.backpack.select().id(5512, 5513, 5514, 5515))
  i.interact("Fill");

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L112-L116

return ctx.bank.opened();

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L120

It would be better to use names. (I'm traversing through consecutive ring3-8 ids, they tend to have consecutive ids)

 

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L143

Action bar may not be active. Make sure to check if legacy mode is disabled. Also, since people can define their own key binds, use: (its selecting menu option instead of doing action bar)

ctx.input.send(ctx.combatBar.actionAt(0).bind())

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L151

Euclidean distance will never be negative. If the distance is incalculable (i.e. separate planes or null), it will return Double#POSITIVE_INFINITY. Also, you don't need to grab the Tile instance from a Tile; it is itself.(fixed)

 

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L190

Step before calling camera turns; this will save time and not wait for the camera to stop turning before stepping.(fixed)

 

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L201-L208

way too repetitive and detectable. Are you trying to move the camera up?(fixed, using api ctx.camera.turnTo)

 

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L211

This will click the object, despite if something is in front of it. Use GameObject#interact(String action, String option) to prevent this, for example:(fixed)

ctx.objects.peek().interact("Enter", ctx.objects.peek().name());

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L259

I imagine these are magic lamps? You'll need to rub each one, so do:(Im rubbing a ring of dueling, and it can be ring of dueling 3-8, so im selectively choose existing one)

for(Item i : ctx.inventory.select().id(MAGIC_LAMPS))
  i.interact("rub");

https://github.com/superchaoran/powerbot/blob/scripts/src/superchaoran/RuneCrafting/SmokeRun.java#L294

One too many brackets.(future)

 

 

----

 

The script has a lot of repetition and easily-detectable patterns. (thanks, will pay attention to that)

 

The script does too many actions in one poll() call (should be limited to 1 each call so the script doesn't hang too long after being suspended).(future)

 

Also, script freezes when I have 1-2 charges left on ring of dueling.

 

zigress, i intentionally keep 1-2 charges of ring of dueling because a ring of dueling(1) can be sold roughly the same price as ring of dueling(8) on g/e, but if you rub it, it's going to disappear. so make sure you have plenty of ring of dueling(8). 
i do spot a halt when fusing the rune on the alter, it may off click to the wizard and end up halting.

Share this post


Link to post

Nice work !!

Could be nice to add support for smaller pouches tho :)

 

Thanks 

On 10/21/2016 at 10:04 AM, Wreckful said:

Dead script

 

Lol this script work fine 

Share this post


Link to post
On 9/29/2016 at 1:14 PM, DamageGfx said:

just sits at the bank..

 

that is not a constructive comment :p

 

tho make sure you backpack is empty before starting at a bank, dont zoom out too far (it may cause a missclick at the altar teleport sequence) and try to start the script at the Castle war bank 

Share this post


Link to post

i made the preset as the screenshot.

but he is clicking on the air runes everytime. why?

 

- starting at bank castle wars

- i do not have any pouches.  lvl to low :)

 

i found it: 

 

when make your preset only add the air talisman and air runes on the same place as the screenshot.

he pick automatic the pure essenc and ring out of the bank later.

Edited by vincenzol
problem solved

Share this post


Link to post

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now