Autonomous

Autonomous Herblore

Recommended Posts

Description: 

Autonomous Herblore is a simple, yet effective herblore bot. It can clean herbs or make potions, while automatically detecting which you are doing and whether or not there is a well close to you.

Screenshots:

3534aqu.jpg

 

2cz7dbl.jpg

 

 

Instructions:

1. Setup Preset 1 with herbs if you would like to clean, or split your preset equally with first and second ingredients if you would like to make potions.

2. Start bot with inventory open near bank.

3. Profit.

 

Script Link: Here

 

Temporarily Unavailable For Updates (2/17/16)

Back kinda.

Not really.

*Wouldn't recommend until antiban is added*

 

*If you experience a bug please post using the following:

1. What were you doing when you experienced the bug?

2. Please include a screenshot for my convenience.

3. Any information you think will be helpful.

Edited by Autonomous
Script causing bans.

Share this post


Link to post


sliske   

- package names should be lowercase

- class names should start with an upper case letter

- https://github.com/powerbot/powerbot/blob/scripts/src/Autonomous/Herblore/autonomousHerblore.java#L209 no need to do this every time repaint runs

- https://github.com/powerbot/powerbot/blob/scripts/src/Autonomous/Herblore/autonomousHerblore.java#L264 store the result from https://github.com/powerbot/powerbot/blob/scripts/src/Autonomous/Herblore/autonomousHerblore.java#L63 rather than running state() again in your paint

-not a massive problem, but you are still using your sw application thread as the topic, which means in a few days your script will be removed from the sdn again like last week

- you should use Condition.wait(Callable<Boolean>) 's instead of Condition.sleep(millis)

 

some of the things [member=mooshe] pointed out on your last application still havent been fixed http://www.powerbot.org/community/topic/1299918-application-autonomous-herblore/?p=15819407

 

- https://github.com/powerbot/powerbot/blob/scripts/src/Autonomous/Herblore/autonomousHerblore.java#L225 you shouldnt be downloading the image in repaint

- https://github.com/powerbot/powerbot/blob/scripts/src/Autonomous/Herblore/autonomousHerblore.java#L272 would be better using GeItem#price imo, whichever you use you should be caching the result, not running this every time repaint runs

- your script is very dependant on exactly where in the inventory items are, you should be using querys to find/interact with items, not itemAt

Edited by sliske

Share this post


Link to post

- package names should be lowercase

- class names should start with an upper case letter

- https://github.com/powerbot/powerbot/blob/scripts/src/Autonomous/Herblore/autonomousHerblore.java#L209 no need to do this every time repaint runs

- https://github.com/powerbot/powerbot/blob/scripts/src/Autonomous/Herblore/autonomousHerblore.java#L264 store the result from https://github.com/powerbot/powerbot/blob/scripts/src/Autonomous/Herblore/autonomousHerblore.java#L63 rather than running state() again in your paint

-not a massive problem, but you are still using your sw application thread as the topic, which means in a few days your script will be removed from the sdn again like last week

- you should use Condition.wait(Callable<Boolean>) 's instead of Condition.sleep(millis)

 

some of the things [member=mooshe] pointed out on your last application still havent been fixed http://www.powerbot.org/community/topic/1299918-application-autonomous-herblore/?p=15819407

 

- https://github.com/powerbot/powerbot/blob/scripts/src/Autonomous/Herblore/autonomousHerblore.java#L225 you shouldnt be downloading the image in repaint

- https://github.com/powerbot/powerbot/blob/scripts/src/Autonomous/Herblore/autonomousHerblore.java#L272 would be better using GeItem#price imo, whichever you use you should be caching the result, not running this every time repaint runs

- your script is very dependant on exactly where in the inventory items are, you should be using querys to find/interact with items, not itemAt

I've fixed several of these mistakes minus the Condition.wait's instead of sleep's, I still use getPrice method, and still dependent on where items are in inventory (mainly because I believe it allows for more ingredients to be mixed rather than limiting by my query). These changes can be reflected in my latest pull request.

Edited by Autonomous

Share this post


Link to post
sliske   

the bot will select the present but won't mix adrenaline potion

latest runescape update broke the inventory, will be fixed in next client update which should be today

Share this post


Link to post
WYD   

latest runescape update broke the inventory, will be fixed in next client update which should be today

this why i just use color XD

Share this post


Link to post
WYD   

wow  color bot

 

very wow

i just hit 4 99s on 10 accs mate

Edited by im everyone

Share this post


Link to post

bot not working for me, i start the script, it goes to bank takes out an inventory of supplies, itll make the load of pots but after that it just logs out and doesn't re-bank for more supplies, been using it past few days no hassle till now

Edited by bentley3k99

Share this post


Link to post
mooieboy   

Hey! I love your script, it's pretty good :)

 

I found 1 bug: when you save an ingredient because of scroll of cleansing, the bot gets stuck because of the extra secondary ingredient.

 

I also have a few tips:

- You can load bankpreset 1 by pressing "1" on your keyboard.

- Instead on clicking on the option "clean" or "mix", you can press on the space bar.

 

 

Hope this helps :) Good luck with this script!

Share this post


Link to post

dude, awesome-ness itself 

 

not one bug, and i have used it so many times...

 

the intelligence is the best part :D


dude, awesome-ness itself 

 

not one bug, and i have used it so many times...

 

the intelligence is the best part :D

Share this post


Link to post

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now